Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Apr 3, 2025

Replace all instances of istanbul ignore comments with c8 ignore syntax across multiple files in the codebase. This change maintains the same code coverage exclusions while updating to the newer c8 coverage tool format.

The changes include:

  • Converting single-line ignores to c8 ignore start/stop blocks
  • Updating existing ignore comments to maintain their original purpose
  • Preserving the explanatory comments for why certain sections are ignored

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Replace all instances of istanbul ignore comments with c8 ignore syntax across
multiple files in the codebase. This change maintains the same code coverage
exclusions while updating to the newer c8 coverage tool format.

The changes include:
- Converting single-line ignores to c8 ignore start/stop blocks
- Updating existing ignore comments to maintain their original purpose
- Preserving the explanatory comments for why certain sections are ignored
@github-actions github-actions bot added the p2 label Apr 3, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 3, 2025 19:34
@mrgrain mrgrain marked this pull request as draft April 3, 2025 19:34
auto-merge was automatically disabled April 3, 2025 19:34

Pull request was converted to draft

@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Apr 3, 2025
@mrgrain mrgrain marked this pull request as ready for review April 3, 2025 19:34
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.67%. Comparing base (38d6443) to head (b0ba11f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   85.10%   85.67%   +0.57%     
==========================================
  Files         223      223              
  Lines       36990    37005      +15     
  Branches     4474     4481       +7     
==========================================
+ Hits        31480    31705     +225     
+ Misses       5413     5203     -210     
  Partials       97       97              
Flag Coverage Δ
suite.unit 85.67% <100.00%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Apr 3, 2025
Merged via the queue into main with commit 7fd6176 Apr 3, 2025
11 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/chore/fix/coverage-ignore branch April 3, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants