refactor(cli): rename logs to logs-monitor
#324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
- Coverage 86.86% 86.85% -0.01%
==========================================
Files 219 220 +1
Lines 35609 35611 +2
Branches 4364 4341 -23
==========================================
- Hits 30932 30931 -1
- Misses 4583 4584 +1
- Partials 94 96 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kaizencc
approved these changes
Apr 3, 2025
mrgrain
force-pushed
the
mrgrain/refactor/logs-monitor
branch
from
eb8104f to
c9dec4e
Compare
mrgrain
force-pushed
the
mrgrain/refactor/logs-monitor
branch
from
9e1601c to
cd1c95f
Compare
mrgrain
force-pushed
the
mrgrain/refactor/logs-monitor
branch
from
cd1c95f to
4e2459b
Compare
We are about to move this module into a different package, and the target package is gitignoring any directory called `logs`. We could just fix the gitignore, but the module name is very inacurate anyway. Therefore we are renaming it. Also moves `rwlock` from `api/utils` to `api`. This was an oversight and doesn't warrant a separate PR. Finally moves some test files into their correct corresponding directories.
mrgrain
force-pushed
the
mrgrain/refactor/logs-monitor
branch
from
4e2459b to
366c0ac
Compare
mrgrain
added a commit
that referenced
this pull request
Apr 4, 2025
We are about to move this module into a different package, and the target package is gitignoring any directory called `logs`. We could just fix the gitignore, but the module name is very inacurate anyway. Therefore we are renaming it. Also moves `rwlock` from `api/utils` to `api`. This was an oversight and doesn't warrant a separate PR. Finally moves some test files into their correct corresponding directories. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are about to move this module into a different package, and the target package is gitignoring any directory called
logs. We could just fix the gitignore, but the module name is very inacurate anyway. Therefore we are renaming it.Also moves
rwlockfromapi/utilstoapi. This was an oversight and doesn't warrant a separate PR.Finally moves some test files into their correct corresponding directories.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license