refactor(toolkit-lib): move payloads out of api #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message payload interfaces never were an api. They just ended up there by chance. Move them to their own top-level module. This has the side-effect that it will make future diffs slightly nicer.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 86.72% 87.38% +0.65%
==========================================
Files 218 218
Lines 35583 35583
Branches 4347 4418 +71
==========================================
+ Hits 30860 31093 +233
+ Misses 4623 4395 -228
+ Partials 100 95 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kaizencc
approved these changes
Apr 3, 2025
auto-merge was automatically disabled
April 3, 2025 23:10
Pull request was closed
mrgrain
added a commit
that referenced
this pull request
Apr 4, 2025
The message payload interfaces never were an api. They just ended up there by chance. Move them to their own top-level module. This has the side-effect that it will make future diffs slightly nicer. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message payload interfaces never were an api. They just ended up there by chance. Move them to their own top-level module. This has the side-effect that it will make future diffs slightly nicer.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license