Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Apr 4, 2025

This intentionally only moves the source, and not the tests. Tests will be moved later to keep the diff size managable. Code is still tested as the tests are still running from aws-cdk package.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Apr 4, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 4, 2025 08:39
@mrgrain mrgrain force-pushed the mrgrain/refact/plugin-auth branch from 3af253b to 5cb4285 Compare April 4, 2025 08:47
@mrgrain mrgrain force-pushed the mrgrain/refact/plugin-auth branch from 5cb4285 to 432d73e Compare April 4, 2025 09:11
@mrgrain mrgrain force-pushed the mrgrain/refact/plugin-auth branch from 432d73e to fa1d992 Compare April 4, 2025 09:12
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.93%. Comparing base (586e1b3) to head (5bb9728).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
- Coverage   86.96%   86.93%   -0.04%     
==========================================
  Files         220      206      -14     
  Lines       35648    34059    -1589     
  Branches     4369     4188     -181     
==========================================
- Hits        31003    29609    -1394     
+ Misses       4545     4358     -187     
+ Partials      100       92       -8     
Flag Coverage Δ
suite.unit 86.93% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain force-pushed the mrgrain/refact/plugin-auth branch from fa1d992 to eeb9df3 Compare April 4, 2025 09:21
@mrgrain mrgrain force-pushed the mrgrain/refact/plugin-auth branch from d065254 to eeb9df3 Compare April 4, 2025 09:28
This intentionally only moves the source, and not the tests. Tests will be moved later to keep the diff size managable. Code is still tested as the tests are still running from `aws-cdk` package.
@mrgrain mrgrain force-pushed the mrgrain/refact/plugin-auth branch from eeb9df3 to 5c1eee5 Compare April 4, 2025 10:17
@mrgrain
Copy link
Contributor Author

mrgrain commented Apr 4, 2025

exempting from integ tests. most passed, only one failed likely due to config of the new atmosphere service. I'm taking the risk.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Apr 4, 2025
Merged via the queue into main with commit 5bf7624 Apr 4, 2025
11 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/refact/plugin-auth branch April 4, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants