-
Notifications
You must be signed in to change notification settings - Fork 69
refactor(toolkit): move aws-auth and plugin to shared package #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3af253b to
5cb4285
Compare
5cb4285 to
432d73e
Compare
432d73e to
fa1d992
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 86.96% 86.93% -0.04%
==========================================
Files 220 206 -14
Lines 35648 34059 -1589
Branches 4369 4188 -181
==========================================
- Hits 31003 29609 -1394
+ Misses 4545 4358 -187
+ Partials 100 92 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fa1d992 to
eeb9df3
Compare
d065254 to
eeb9df3
Compare
This intentionally only moves the source, and not the tests. Tests will be moved later to keep the diff size managable. Code is still tested as the tests are still running from `aws-cdk` package.
eeb9df3 to
5c1eee5
Compare
|
exempting from integ tests. most passed, only one failed likely due to config of the new atmosphere service. I'm taking the risk. |
This intentionally only moves the source, and not the tests. Tests will be moved later to keep the diff size managable. Code is still tested as the tests are still running from
aws-cdkpackage.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license