Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Apr 29, 2025

Move all code and tests from tmp-toolkit-helpers to toolkit-lib. Remove the now empty package. Made necessary changes to imports, config and tests. No functional code changes!


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain changed the title Tmp move refactor(toolkit-lib): move code from tmp-toolkit-helpers Apr 29, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 29, 2025 10:41
@github-actions github-actions bot added the p2 label Apr 29, 2025
@github-actions
Copy link
Contributor

Total lines changed 2510 is greater than 1000. Please consider breaking this PR down.

@mrgrain mrgrain marked this pull request as ready for review April 29, 2025 13:40
Signed-off-by: github-actions <github-actions@github.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.94%. Comparing base (f12ec97) to head (45ea1c7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   80.27%   80.94%   +0.66%     
==========================================
  Files          66       65       -1     
  Lines        6894     6900       +6     
  Branches      790      797       +7     
==========================================
+ Hits         5534     5585      +51     
+ Misses       1340     1295      -45     
  Partials       20       20              
Flag Coverage Δ
suite.unit 80.94% <100.00%> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain added this pull request to the merge queue Apr 29, 2025
Merged via the queue into main with commit 2093af0 Apr 29, 2025
29 checks passed
@mrgrain mrgrain deleted the tmp-move branch April 29, 2025 16:03
@mrgrain mrgrain self-assigned this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-size-check Skips PR size check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants