Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Apr 29, 2025

We used to try to upload all logs under the same artifact name, but we need to make them explicitly unique per matrix job otherwise the names collide.

Also include a link to the artifact name in the summary, just for kicks.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

We used to try to upload all logs under the same artifact name,
but we need to make them explicitly unique per matrix job otherwise
the names collide.

Also include a link to the artifact name in the summary, just for kicks.
@rix0rrr rix0rrr requested a review from a team April 29, 2025 14:27
@aws-cdk-automation aws-cdk-automation requested a review from a team April 29, 2025 14:27
@rix0rrr rix0rrr self-assigned this Apr 29, 2025
@github-actions github-actions bot added the p2 label Apr 29, 2025
Signed-off-by: github-actions <github-actions@github.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.02%. Comparing base (f12ec97) to head (9f05367).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   80.27%   80.02%   -0.25%     
==========================================
  Files          66       66              
  Lines        6894     6894              
  Branches      790      786       -4     
==========================================
- Hits         5534     5517      -17     
- Misses       1340     1356      +16     
- Partials       20       21       +1     
Flag Coverage Δ
suite.unit 80.02% <ø> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Apr 30, 2025
Merged via the queue into main with commit d4fa4ff Apr 30, 2025
20 checks passed
@aws-cdk-automation aws-cdk-automation deleted the huijbers/unique-artifacts branch April 30, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants