refactor(toolkit-lib): move tests from CLI to toolkit-lib #428
Conversation
mrgrain
had a problem deploying
to
integ-approval
GitHub Actions
Failure
| branches: 76, | ||
| functions: 87, | ||
| lines: 82, | ||
| lines: 81, |
There was a problem hiding this comment.
Yeah it's weird. It passes in build with the previous value, but not in codecov
There was a problem hiding this comment.
Yeah it's weird. It passes in build with the previous value, but not in codecov
| "branches": 76, | ||
| "functions": 87, | ||
| "lines": 82 | ||
| "lines": 81 |
| const accountId = this.defaultAccounts.length === 0 | ||
| ? '123456789012' | ||
| : this.defaultAccounts.shift()!; |
There was a problem hiding this comment.
sure but why not const accountId = this.defaultAccounts.shift() ?? '123456789012';
There was a problem hiding this comment.
Cause I just copied it!
There was a problem hiding this comment.
well whoever wrote that seems to not know that the nullish coalescer exists...
mrgrain
had a problem deploying
to
integ-approval
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
- Coverage 79.86% 79.15% -0.72%
==========================================
Files 65 54 -11
Lines 6900 6889 -11
Branches 787 773 -14
==========================================
- Hits 5511 5453 -58
- Misses 1366 1418 +52
+ Partials 23 18 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
Moves the tests that belong with the toolkit-lib into the toolkit-lib.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license