Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Apr 30, 2025

We used to only run integ tests for PRs targeting main.

That makes it impossible to run integ tests for stacked PRs, which is inconvenient. Remove the restriction and run integ tests on all PRs.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

We used to only run integ tests for PRs targeting `main`.

That makes it impossible to run integ tests for stacked PRs,
which is inconvenient. Remove the restriction and run integ
tests on all PRs.
@rix0rrr rix0rrr requested a review from a team April 30, 2025 10:20
@rix0rrr rix0rrr temporarily deployed to integ-approval April 30, 2025 10:20 — with GitHub Actions Inactive
@github-actions github-actions bot added the p2 label Apr 30, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 30, 2025 10:22
Signed-off-by: github-actions <github-actions@github.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.15%. Comparing base (6f1df5d) to head (bb13bc8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   79.15%   79.15%           
=======================================
  Files          54       54           
  Lines        6889     6889           
  Branches      773      773           
=======================================
  Hits         5453     5453           
  Misses       1418     1418           
  Partials       18       18           
Flag Coverage Δ
suite.unit 79.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Apr 30, 2025
Merged via the queue into main with commit cf68e32 Apr 30, 2025
20 checks passed
@aws-cdk-automation aws-cdk-automation deleted the huijbers/integ-tests-all-branches branch April 30, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants