Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Apr 30, 2025

We previously bundled some entrypoints and their type declarations because they containted code that lived in the
not published shared helper package. With that package now remove, bundling is no longer needed.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 30, 2025 10:53
@github-actions github-actions bot added the p2 label Apr 30, 2025
Base automatically changed from toolkit-lib-tests-move to main April 30, 2025 11:41
@mrgrain mrgrain force-pushed the mrgrain/refactor/toolkit-lib-remove-build-steps branch from 9561b9e to 4f5d17a Compare April 30, 2025 12:19
@mrgrain mrgrain self-assigned this Apr 30, 2025
@mrgrain mrgrain force-pushed the mrgrain/refactor/toolkit-lib-remove-build-steps branch from 4f5d17a to 8b2b54e Compare April 30, 2025 14:07
@mrgrain mrgrain temporarily deployed to integ-approval May 1, 2025 08:34 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.15%. Comparing base (6f1df5d) to head (22dfe6f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   79.15%   79.15%           
=======================================
  Files          54       54           
  Lines        6889     6889           
  Branches      773      773           
=======================================
  Hits         5453     5453           
  Misses       1418     1418           
  Partials       18       18           
Flag Coverage Δ
suite.unit 79.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue May 1, 2025
Merged via the queue into main with commit 9bc66f1 May 1, 2025
20 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/refactor/toolkit-lib-remove-build-steps branch May 1, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants