Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Apr 30, 2025

Fixes unstable tests sometimes timing out or failing with TypeError: this._getSession is not a function

Seems to come down to this report:
mswjs/interceptors#675

But in general nock v14 seems to have a lot of problems:
nock/nock#2857
nock/nock#2855
nock/nock#2849
nock/nock#2846
nock/nock#2839
nock/nock#2832
nock/nock#2828


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain temporarily deployed to integ-approval April 30, 2025 12:43 — with GitHub Actions Inactive
@github-actions github-actions bot added the p2 label Apr 30, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 30, 2025 12:44
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.30%. Comparing base (6f1df5d) to head (ab1ec01).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
+ Coverage   79.15%   79.30%   +0.14%     
==========================================
  Files          54       54              
  Lines        6889     6889              
  Branches      773      781       +8     
==========================================
+ Hits         5453     5463      +10     
+ Misses       1418     1406      -12     
- Partials       18       20       +2     
Flag Coverage Δ
suite.unit 79.30% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Apr 30, 2025
Merged via the queue into main with commit 40c6042 Apr 30, 2025
20 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/chore/nock-fix branch April 30, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants