chore(cli): lint test files #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
commented
May 1, 2025
Comment on lines
+1005
to
+1006
| 'aws-sdk-client-mock', | ||
| 'aws-sdk-client-mock-jest', |
Contributor
Author
There was a problem hiding this comment.
These were missing dev deps that eslint discovered.
mrgrain
commented
May 1, 2025
|
|
||
| test('require approval by default - respond no', async () => { | ||
| expect(() => requestResponse('n', plainMessage({ | ||
| await expect(() => requestResponse('n', plainMessage({ |
Contributor
Author
There was a problem hiding this comment.
this was missing before, all promises must be awaited
mrgrain
commented
May 1, 2025
| deployments: new FakeCloudFormation({}), | ||
| }); | ||
| stderrMock.mockImplementation((...x) => { | ||
| // eslint-disable-next-line no-console |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 79.15% 79.15%
=======================================
Files 54 54
Lines 6889 6889
Branches 773 772 -1
=======================================
Hits 5453 5453
Misses 1418 1418
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rix0rrr
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were previously ignored, presumingly because they did not follow most of our linting rules. However now a lot less tests are in the CLI package (most moved to toolkit-lib) so we can safely re-enable linting of test files.
Added
'@typescript-eslint/unbound-method': 'off'for test files, since there were many violations of this and it doesn't seem necessary to enforce this rule in test code.Most test code changes are automated. I've annotated the few manual fixes I made.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license