chore: enable eslint for the repo config #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
merged commit 464ece5
into
mrgrain/chore/re-add-linter-rules
5 checks passed
mrgrain
commented
Feb 19, 2025
Comment on lines
-41
to
-52
| // Require all imported dependencies are actually declared in package.json | ||
| 'import/no-extraneous-dependencies': [ | ||
| 'error', | ||
| { | ||
| devDependencies: [ // Only allow importing devDependencies from: | ||
| '**/build-tools/**', // --> Build tools | ||
| '**/test/**', // --> Unit tests | ||
| ], | ||
| optionalDependencies: false, // Disallow importing optional dependencies (those shouldn't be in use in the project) | ||
| }, | ||
| ], | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Removed this in favor of the projen built-in rule, which is pretty much the same but allows for a dynamic configuration of the paths in devDependencies.
mrgrain
commented
Feb 19, 2025
Contributor
Author
There was a problem hiding this comment.
Change here and in the other package lint configs are due to now using the projen built-in rule for import/no-extraneous-dependencies.
As you can see these are pretty much the same. The main difference is that we now allow imports of peerDependencies which seems acceptable if not desired.
mrgrain
commented
Feb 19, 2025
Comment on lines
+184
to
+194
| // Eslint for projen config | ||
| // @ts-ignore | ||
| repoProject.eslint = new pj.javascript.Eslint(repoProject, { | ||
| tsconfigPath: `./${repoProject.tsconfigDev.fileName}`, | ||
| dirs: [], | ||
| devdirs: ['projenrc', '.projenrc.ts'], | ||
| fileExtensions: ['.ts', '.tsx'], | ||
| lintProjenRc: false, | ||
| }); | ||
|
|
||
| const repo = configureProject(repoProject); |
Contributor
Author
There was a problem hiding this comment.
This is the only actual change in here: We are adding a custom eslint config for the repo root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license