chore: enforce curly-newline lint rule to comply with COE action item #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
kaizencc
reviewed
Feb 19, 2025
| private readonly cli: (args: string[]) => Promise<number | void>, | ||
| ) {} | ||
| ) { | ||
| } |
Contributor
Author
There was a problem hiding this comment.
We looked at this and we cannot enforce this consistently because we want to allow empty statements with comments inside of them.
kaizencc
reviewed
Feb 19, 2025
| * Query input for looking up a load balancer | ||
| */ | ||
| export interface LoadBalancerContextQuery extends LoadBalancerFilter {} | ||
| export interface LoadBalancerContextQuery extends LoadBalancerFilter { |
otaviomacedo
approved these changes
Feb 19, 2025
aws-cdk-automation
deleted the
mrgrain/chore/lint-curly-all-the-things
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license