Skip to content

Conversation

@iankhou
Copy link
Contributor

@iankhou iankhou commented Jul 28, 2025

Fixes #740

The cdk drift action lists UNKNOWN for resources/stacks when CloudFormation returns that value (effective August 14).

This follows a new change in the CloudFormation API. Previously, UNKNOWN was not available, and stacks/resources that fit such a description would have been reported as unchanged.

Brought line coverage for @aws-cdk/toolkit-lib/lib/api/drift to 100%.
Screenshot 2025-09-01 at 02 59 27

  • UNKNOWN support
  • Unit Test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@iankhou iankhou self-assigned this Jul 28, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team July 28, 2025 18:01
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.34%. Comparing base (0e27c14) to head (666ad44).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
- Coverage   83.06%   82.34%   -0.73%     
==========================================
  Files          65       65              
  Lines        9509     9509              
  Branches     1123     1108      -15     
==========================================
- Hits         7899     7830      -69     
- Misses       1578     1648      +70     
+ Partials       32       31       -1     
Flag Coverage Δ
suite.unit 82.34% <ø> (-0.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iankhou iankhou temporarily deployed to integ-approval July 28, 2025 19:08 — with GitHub Actions Inactive
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think from a DX perspective unchecked and unknown are pretty much the same. I propose you just piggy back on unchecked.

@jiayiwang7 jiayiwang7 added p1 and removed p2 labels Jul 30, 2025
@iankhou iankhou force-pushed the iankhou-drift-unknown branch from 5c6476a to aa80efd Compare August 21, 2025 17:42
@mrgrain mrgrain added this pull request to the merge queue Sep 1, 2025
@iankhou iankhou removed this pull request from the merge queue due to a manual request Sep 1, 2025
@iankhou iankhou added this pull request to the merge queue Sep 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 1, 2025
@mrgrain mrgrain enabled auto-merge September 2, 2025 00:56
@mrgrain mrgrain added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit aec389c Sep 2, 2025
28 checks passed
@mrgrain mrgrain deleted the iankhou-drift-unknown branch September 2, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(drift): handle new CloudFormation drift detection "UNKNOWN" status

5 participants