-
Notifications
You must be signed in to change notification settings - Fork 69
feat(cli): count resources/stacks with UNKNOWN drift status as unchecked
#747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
==========================================
- Coverage 83.06% 82.34% -0.73%
==========================================
Files 65 65
Lines 9509 9509
Branches 1123 1108 -15
==========================================
- Hits 7899 7830 -69
- Misses 1578 1648 +70
+ Partials 32 31 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think from a DX perspective unchecked and unknown are pretty much the same. I propose you just piggy back on unchecked.
5c6476a to
aa80efd
Compare
Fixes #740
The
cdk driftaction listsUNKNOWNfor resources/stacks when CloudFormation returns that value (effective August 14).This follows a new change in the CloudFormation API. Previously,
UNKNOWNwas not available, and stacks/resources that fit such a description would have been reported as unchanged.Brought line coverage for

@aws-cdk/toolkit-lib/lib/api/driftto 100%.UNKNOWNsupportBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license