-
Notifications
You must be signed in to change notification settings - Fork 40
feat(cli): add sts:TagSession permission to trusted accounts on bootstrap #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add sts:TagSession permission to trusted accounts on bootstrap #762
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
==========================================
+ Coverage 81.16% 81.21% +0.04%
==========================================
Files 61 61
Lines 8267 8267
Branches 952 950 -2
==========================================
+ Hits 6710 6714 +4
+ Misses 1529 1528 -1
+ Partials 28 25 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks for your contribution!
…trap (#762) ## Description Accounts bootstrapped with `--trust` or `--trust-for-lookup` need `sts:TagSession` permissions in AssumeRolePolicy. I got errors during `cdk deploy` run in CD pipelines executed on EKS cluster on the trusted account. Error message: Could not assume role in target account using current credentials (which are for account `<TRUSTED_ACCOUT>`) User: `arn:aws:sts::<TRUSTED_ACCOUT>:assumed-role/<eks-pod-role>` is not authorized to perform: `sts:TagSession` on resource: `arn:aws:iam::<TARGET_ACCOUNT>:role/cdk-hnb659fds-lookup-role-<TARGET_ACCOUNT>-us-east-1` Troubleshooting revealed that DeploymentActionRole, FilePublishingRole, ImagePublishingRole, LookupRole don't have `sts:TagSession`. After updating AssumeRolePolicy `cdk deploy` worked normally. Fixes aws/aws-cdk#31557 --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Description
Accounts bootstrapped with
--trust
or--trust-for-lookup
needsts:TagSession
permissions in AssumeRolePolicy.I got errors during
cdk deploy
run in CD pipelines executed on EKS cluster on the trusted account.Error message:
Could not assume role in target account using current credentials (which are for account
<TRUSTED_ACCOUT>
) User:arn:aws:sts::<TRUSTED_ACCOUT>:assumed-role/<eks-pod-role>
is not authorized to perform:sts:TagSession
on resource:arn:aws:iam::<TARGET_ACCOUNT>:role/cdk-hnb659fds-lookup-role-<TARGET_ACCOUNT>-us-east-1
Troubleshooting revealed that DeploymentActionRole, FilePublishingRole, ImagePublishingRole, LookupRole don't have
sts:TagSession
. After updating AssumeRolePolicycdk deploy
worked normally.Fixes aws/aws-cdk#31557
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license