feat: add local template support with --from-path option #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohang9000
had a problem deploying
to
integ-approval
GitHub Actions
Failure
iankhou
requested changes
Aug 5, 2025
Contributor
iankhou
left a comment
iankhou
left a comment
There was a problem hiding this comment.
I left some comments about code efficiency and validations.
Also, about option exclusivity for the --from-path option.
rohang9000
had a problem deploying
to
integ-approval
GitHub Actions
Failure
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #763 +/- ##
==========================================
+ Coverage 80.88% 82.60% +1.72%
==========================================
Files 63 64 +1
Lines 8599 9465 +866
Branches 1028 1107 +79
==========================================
+ Hits 6955 7819 +864
+ Misses 1614 1612 -2
- Partials 30 34 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rohang9000
had a problem deploying
to
integ-approval
GitHub Actions
Failure
iankhou
requested changes
Aug 7, 2025
Contributor
iankhou
left a comment
iankhou
left a comment
There was a problem hiding this comment.
Let's handle flag conflicts at yargs, more details in comments. Some questions about error-handling, other minor corrections.
rohang9000
had a problem deploying
to
integ-approval
GitHub Actions
Failure
rohang9000
force-pushed
the
feat/local-template-support
branch
from
95ce3ec to
dd5139e
Compare
rohang9000
had a problem deploying
to
integ-approval
GitHub Actions
Failure
aws-cdk-automation
had a problem deploying
to
integ-approval
GitHub Actions
Failure
rohang9000
force-pushed
the
feat/local-template-support
branch
from
c882bc2 to
54e20f1
Compare
rohang9000
had a problem deploying
to
integ-approval
GitHub Actions
Failure
Signed-off-by: github-actions <[email protected]>
aws-cdk-automation
had a problem deploying
to
integ-approval
GitHub Actions
Failure
rohang9000
had a problem deploying
to
integ-approval
GitHub Actions
Failure
rohang9000
had a problem deploying
to
integ-approval
GitHub Actions
Failure
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 26, 2025
This PR adds local template support through the new `--from-path` CLI option. Users can initialize CDK projects from local custom templates, copying the template as is without placeholder processing. The feature includes language auto-detection when templates contain a single language option and error handling for invalid paths. 3 new test cases covering basic local template functionality, language auto-detection, and error handling scenarios were added. Fixes # --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]> Co-authored-by: Ian Hou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds local template support through the new
--from-pathCLI option. Users can initialize CDK projects from local custom templates, copying the template as is without placeholder processing.The feature includes language auto-detection when templates contain a single language option and error handling for invalid paths. 3 new test cases covering basic local template functionality, language auto-detection, and error handling scenarios were added.
Fixes #
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license