Skip to content

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Aug 6, 2025

This PR includes the following

  • more robust trace messaging for telemetry success / failure
  • use of Funnel class to combine FileSink and EndpointSink
  • update integ tests to assert on trace messages that the telemetry sent returns 200 OK

The tests work if the endpoint provided is included as an env variable TELEMETRY_ENDPOINT


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 6, 2025 18:57
@kaizencc kaizencc changed the title feat: telemetry sent to endpoint feat(cli): telemetry sent to endpoint Aug 6, 2025
Signed-off-by: github-actions <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 55.81395% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.52%. Comparing base (5fc1b13) to head (09909a7).

Files with missing lines Patch % Lines
packages/aws-cdk/lib/cli/io-host/cli-io-host.ts 58.82% 14 Missing ⚠️
...es/aws-cdk/lib/cli/telemetry/sink/endpoint-sink.ts 42.85% 4 Missing ⚠️
...ges/aws-cdk/lib/cli/telemetry/collect-telemetry.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
- Coverage   82.60%   82.52%   -0.09%     
==========================================
  Files          64       64              
  Lines        9465     9488      +23     
  Branches     1106     1109       +3     
==========================================
+ Hits         7819     7830      +11     
- Misses       1612     1624      +12     
  Partials       34       34              
Flag Coverage Δ
suite.unit 82.52% <55.81%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants