Skip to content

Conversation

@vivian12300
Copy link
Contributor

When a user runs cdk flags, a table is displayed with information about their feature flags. This PR omits the intentionally unconfigured feature flags from the table and makes the table more visually appealing.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.88%. Comparing base (409f8e7) to head (99207a1).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
packages/aws-cdk/lib/commands/flag-operations.ts 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
- Coverage   81.42%   80.88%   -0.55%     
==========================================
  Files          63       63              
  Lines        8602     8599       -3     
  Branches     1034     1029       -5     
==========================================
- Hits         7004     6955      -49     
- Misses       1567     1615      +48     
+ Partials       31       29       -2     
Flag Coverage Δ
suite.unit 80.88% <78.94%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment.

Also, these 2 changes should probably be different PRs (though I'm guilty of combining changes into a single PR all the time as well 😈)

@rix0rrr rix0rrr changed the title fix: omit intentionally unconfigured flags from table and improve table display fix(cli): flags command shows unnecessary flags, not all table rows have vertical lines Aug 14, 2025
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Aug 26, 2025
Merged via the queue into aws:main with commit 5128946 Aug 26, 2025
28 checks passed
@vivian12300 vivian12300 deleted the flags-table branch August 26, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants