-
Notifications
You must be signed in to change notification settings - Fork 69
fix(cli): flags command shows unnecessary flags, not all table rows have vertical lines #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
==========================================
- Coverage 81.42% 80.88% -0.55%
==========================================
Files 63 63
Lines 8602 8599 -3
Branches 1034 1029 -5
==========================================
- Hits 7004 6955 -49
- Misses 1567 1615 +48
+ Partials 31 29 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rix0rrr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment.
Also, these 2 changes should probably be different PRs (though I'm guilty of combining changes into a single PR all the time as well 😈)
When a user runs
cdk flags, a table is displayed with information about their feature flags. This PR omits the intentionally unconfigured feature flags from the table and makes the table more visually appealing.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license