Skip to content

Conversation

@ren-yamanashi
Copy link
Contributor

@ren-yamanashi ren-yamanashi commented Aug 22, 2025

Fixes #748

Description Changes

Extended the --language option values for the cdk init and cdk migrate commands to support shorthand aliases for language like ts and js.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@ren-yamanashi ren-yamanashi changed the title feat(cli): cdk init support shorthand aliases for languages feat(cli): cdk init and cdk migrate support shorthand aliases for languages Aug 23, 2025
@ren-yamanashi ren-yamanashi marked this pull request as ready for review August 23, 2025 09:13
@ren-yamanashi ren-yamanashi changed the title feat(cli): cdk init and cdk migrate support shorthand aliases for languages feat(cli): support shorthand aliases for languages Aug 23, 2025
Copy link
Contributor

@iankhou iankhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement for usability. Can we add a negative test case for invalid languages/aliases for init and migrate?

@ren-yamanashi
Copy link
Contributor Author

ren-yamanashi commented Aug 27, 2025

@iankhou

Thank you for the approval!

The build was failing, so I've made the necessary minor fixes.
Could you please approve (and run CI build) again?


commits:

da364b1

6f884a6

@iankhou iankhou enabled auto-merge August 28, 2025 02:42
@iankhou iankhou self-assigned this Aug 28, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.83%. Comparing base (5fc1b13) to head (6f884a6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #814      +/-   ##
==========================================
+ Coverage   82.60%   82.83%   +0.22%     
==========================================
  Files          64       65       +1     
  Lines        9465     9509      +44     
  Branches     1106     1120      +14     
==========================================
+ Hits         7819     7877      +58     
+ Misses       1612     1598      -14     
  Partials       34       34              
Flag Coverage Δ
suite.unit 82.83% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iankhou iankhou added this pull request to the merge queue Aug 29, 2025
Merged via the queue into aws:main with commit 7ad2e9c Aug 29, 2025
28 checks passed
@ren-yamanashi ren-yamanashi deleted the feat/748-cdk-init-language branch November 10, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(init) cdk init: should support shorthand aliases for languages

3 participants