refactor(cli): re-organize api and utils #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
mrgrain
commented
Feb 20, 2025
|
|
||
| cli.preCompileTask.prependExec('./generate.sh'); | ||
| cli.preCompileTask.prependExec('ts-node scripts/user-input-gen.ts'); | ||
| cli.preCompileTask.prependExec('ts-node --prefer-ts-exts scripts/user-input-gen.ts'); |
Contributor
Author
There was a problem hiding this comment.
This was need to make the build more manageable. Otherwise the script would always use the js file and you would need to manually delete it.
mrgrain
commented
Feb 20, 2025
Contributor
Author
There was a problem hiding this comment.
There were 2 separate test files in different directories for this. I have consolidated into a single file.
iliapolo
approved these changes
Feb 20, 2025
Contributor
Author
|
Overriding merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation of splitting out certain parts of the code into a separate library that can than be shared between
aws-cdk(the CLI) andtoolkit-lib(the Toolkit lib).No functional changes! Only moving files and updating imports.
Specifically prepares for:
ioHostinwork-graphioHostinstack-eventsutilsinto a the shared libraryBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license