fix(cli): fails to load credentials if both containerToken and containerTokenFile are set #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerTokenFile are set If both `$AWS_CONTAINER_AUTHORIZATION_TOKEN` and `$AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE` are set, the SDK wants to emit a warning. Because of the way it calls the `logger.warn()` function, the reference to `this` is lost and we try to look up a member on `undefined` which then fails and no credentials are loaded at all. Reported as an upstream bug to SDKv3, but in order to expedite the fix we also guard against it ourselvses by locally binding `this` before we pass our logger object to the SDK.
rix0rrr
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #829 +/- ##
==========================================
+ Coverage 82.60% 82.85% +0.24%
==========================================
Files 64 65 +1
Lines 9465 9509 +44
Branches 1106 1117 +11
==========================================
+ Hits 7819 7879 +60
+ Misses 1612 1598 -14
+ Partials 34 32 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
otaviomacedo
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If both
$AWS_CONTAINER_AUTHORIZATION_TOKENand$AWS_CONTAINER_AUTHORIZATION_TOKEN_FILEare set, the SDK wants to emit a warning.Because of the way it calls the
logger.warn()function, the reference tothisis lost and we try to look up a member onundefinedwhich then fails and no credentials are loaded at all.Reported as an upstream bug to SDKv3, but in order to expedite the fix we also guard against it ourselvses by locally binding
thisbefore we pass our logger object to the SDK.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license