fix(cli): text not readable in light terminals #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `chalk.white`, the text is hard to read on terminals with light backgrounds. Fixes aws#751
ayosec
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
mrgrain
changed the title
chalk.reset instead of chalk.whitechalk.reset instead of chalk.white
mrgrain
changed the title
chalk.reset instead of chalk.white
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 83.22% 84.03% +0.81%
==========================================
Files 65 65
Lines 9554 9554
Branches 1123 1151 +28
==========================================
+ Hits 7951 8029 +78
+ Misses 1581 1499 -82
- Partials 22 26 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
approved these changes
Sep 9, 2025
Contributor
|
Looks good, thank you! @ayosec I'm taking care of the PR from here. No need to interact with it anymore, especially don't update the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
chalk.white, the text is hard to read on terminals with light backgrounds.chalk.resetworks as expected in both dark and light background.Fixes #751
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license