chore: enable trusted publishing for releases to npm and pypi #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliapolo
had a problem deploying
to
integ-approval
GitHub Actions
Failure
iliapolo
commented
Sep 11, 2025
| authorUrl: 'https://aws.amazon.com', | ||
| authorOrganization: true, | ||
| releasableCommits: pj.ReleasableCommits.featuresAndFixes('.'), | ||
| releaseEnvironment: 'releasing', |
Contributor
Author
There was a problem hiding this comment.
We already have a releasing environment with the necessary branch protection rule. It is currently only used to publish some of our assets to AWS accounts. I thought about creating a dedicated environment for the package manager releases, but I don't see much value in that.
mrgrain
approved these changes
Sep 11, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
+ Coverage 83.48% 83.83% +0.35%
==========================================
Files 65 65
Lines 9554 9554
Branches 1134 1138 +4
==========================================
+ Hits 7976 8010 +34
+ Misses 1553 1520 -33
+ Partials 25 24 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Draft because we might not be able to move pypi just yet |
iankhou
pushed a commit
that referenced
this pull request
Oct 7, 2025
This allows us to remove NPM and PyPI tokens from our secrets. Draft until I also make the necessary changes in our NPM and PyPI accounts. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove NPM and PyPI tokens from our secrets. Draft until I also make the necessary changes in our NPM and PyPI accounts.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license