Skip to content

Conversation

@iliapolo
Copy link
Contributor

For jsii packages, the NPM publishing takes a different code path.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 11, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team September 11, 2025 15:23
@iliapolo iliapolo added the pr/exempt-integ-test Skips the integ test steps if set. label Sep 11, 2025
@iliapolo iliapolo closed this Sep 11, 2025
auto-merge was automatically disabled September 11, 2025 15:23

Pull request was closed

@iliapolo iliapolo reopened this Sep 11, 2025
@iliapolo iliapolo enabled auto-merge September 11, 2025 15:26
Signed-off-by: github-actions <[email protected]>
@iliapolo iliapolo added this pull request to the merge queue Sep 11, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.49%. Comparing base (abadf13) to head (0bc8a64).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #843      +/-   ##
==========================================
- Coverage   83.48%   82.49%   -0.99%     
==========================================
  Files          65       65              
  Lines        9554     9554              
  Branches     1134     1115      -19     
==========================================
- Hits         7976     7882      -94     
- Misses       1553     1650      +97     
+ Partials       25       22       -3     
Flag Coverage Δ
suite.unit 82.49% <ø> (-0.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into main with commit 9a567ec Sep 11, 2025
12 checks passed
@iliapolo iliapolo deleted the epolon/jsii-npm-trusted-publishing branch September 11, 2025 15:47
iankhou pushed a commit that referenced this pull request Oct 7, 2025
For jsii packages, the NPM publishing takes a different code path.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

---------

Signed-off-by: github-actions <[email protected]>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants