Skip to content

Conversation

@iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Sep 11, 2025

Trusted publishing is only supported starting from NPM 11.5.1 , which is available in Node 24.x

See https://projen.io/docs/publishing/trusted-publishing/#meeting-the-npm-version-requirement


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 11, 2025 18:33
@github-actions github-actions bot added the p2 label Sep 11, 2025
@iliapolo iliapolo changed the title chore: use node 24.x for publishing jobs chore: bump npm version in publish jobs to allow for trusted publishing Sep 11, 2025
@iliapolo iliapolo changed the title chore: bump npm version in publish jobs to allow for trusted publishing chore: bump node (and npm) version in publish jobs to allow for trusted publishing Sep 11, 2025
@iliapolo iliapolo added the pr/exempt-integ-test Skips the integ test steps if set. label Sep 11, 2025
@iliapolo iliapolo closed this Sep 11, 2025
auto-merge was automatically disabled September 11, 2025 18:35

Pull request was closed

@iliapolo iliapolo reopened this Sep 11, 2025
Signed-off-by: github-actions <[email protected]>
@iliapolo iliapolo enabled auto-merge September 11, 2025 18:41
@iliapolo iliapolo added this pull request to the merge queue Sep 11, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.64%. Comparing base (85d6889) to head (e8ca5b9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
+ Coverage   82.70%   83.64%   +0.93%     
==========================================
  Files          65       65              
  Lines        9554     9554              
  Branches     1121     1136      +15     
==========================================
+ Hits         7902     7991      +89     
+ Misses       1629     1538      -91     
- Partials       23       25       +2     
Flag Coverage Δ
suite.unit 83.64% <ø> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into main with commit b45b1ab Sep 11, 2025
12 checks passed
@iliapolo iliapolo deleted the epolon/publish-jobs-node-version branch September 11, 2025 18:55
iankhou pushed a commit that referenced this pull request Oct 7, 2025
…ed publishing (#845)

Trusted publishing is only supported starting from NPM 11.5.1 , which is
available in Node 24.x

> See
https://projen.io/docs/publishing/trusted-publishing/#meeting-the-npm-version-requirement

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

---------

Signed-off-by: github-actions <[email protected]>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants