fix(cli): stack filter positional arg is not being respected #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaviomacedo
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
otaviomacedo
commented
Sep 12, 2025
| @@ -0,0 +1,26 @@ | |||
| const cdk = require('aws-cdk-lib'); | |||
Contributor
Author
There was a problem hiding this comment.
Creating a new app, to avoid cluttering the existing one, used for other refactoring scenarios.
| desc: 'Whether to do the refactor without asking for confirmation', | ||
| }, | ||
| }, | ||
| arg: { |
Contributor
Author
There was a problem hiding this comment.
This is the actual fix. The rest follows from it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #846 +/- ##
==========================================
+ Coverage 82.69% 83.79% +1.09%
==========================================
Files 65 65
Lines 9554 9558 +4
Branches 1122 1140 +18
==========================================
+ Hits 7901 8009 +108
+ Misses 1630 1525 -105
- Partials 23 24 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
otaviomacedo
temporarily deployed
to
run-tests
GitHub Actions
Inactive
mrgrain
approved these changes
Sep 12, 2025
iankhou
pushed a commit
that referenced
this pull request
Oct 7, 2025
At some point, the positional argument was lost, and there were no tests for it. Add it to `cli-config.ts`. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, the positional argument was lost, and there were no tests for it.
Add it to
cli-config.ts.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license