chore(cli-lib-alpha): stop releasing deprecated package #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
==========================================
+ Coverage 81.91% 83.00% +1.09%
==========================================
Files 71 71
Lines 10350 10345 -5
Branches 1268 1289 +21
==========================================
+ Hits 8478 8587 +109
+ Misses 1832 1718 -114
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
had a problem deploying
to
integ-approval
GitHub Actions
Failure
mrgrain
force-pushed
the
mrgrain/feat/cli-lib-alpha/remove-from-release-workflow
branch
from
5680ed8 to
6de0e28
Compare
mrgrain
changed the title
Contributor
|
Total lines changed 27324 is greater than 1000. Please consider breaking this PR down. |
Contributor
Author
No that's fine. I'm removing things on purpose. |
rix0rrr
approved these changes
Oct 6, 2025
aws-cdk-automation
deleted the
mrgrain/feat/cli-lib-alpha/remove-from-release-workflow
branch
iankhou
pushed a commit
that referenced
this pull request
Oct 7, 2025
Stop releasing the deprecated `@aws-cdk/cli-lib-alpha` package. This change removes the package from the code base and integ tests. If we ever need to release it again, we can revert this PR. I tried to just disable releasing, but then integ tests fail and I think removing it all in one PR is just easier if we need to go back to it. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
kaizencc
reviewed
Oct 10, 2025
Comment on lines
-337
to
-339
| // This is necessary because the new versioning of @aws-cdk/cli-lib-alpha | ||
| // matches the CLI and not the framework. | ||
| CLI_LIB_VERSION_MIRRORS_CLI: 'true', |
Contributor
There was a problem hiding this comment.
this change could be the reason why we don't pick up the right version anymore
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 10, 2025
#905 intended to trigger a release for `@aws-cdk-testing/cli-integ`, where it did not rely on the deprecated `cli-lib-alpha` module. because it was marked as a chore, the release was skipped and the latest version still runs the tests that were removed in #905. These tests are now failing because they cannot find the right version of `cli-lib-alpha`. By releasing a version of `@aws-cdk-testing/cli-integ`, we won't have to worry about this anymore. this PR is intended to trigger a release and nothing else. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop releasing the deprecated
@aws-cdk/cli-lib-alphapackage. This change removes the package from the code base and integ tests. If we ever need to release it again, we can revert this PR.I tried to just disable releasing, but then integ tests fail and I think removing it all in one PR is just easier if we need to go back to it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license