Skip to content

chore(cli): ensure version tests don't make network calls #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aws-cdk-automation merged 1 commit into from
Feb 21, 2025
Merged

chore(cli): ensure version tests don't make network calls #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/aws-cdk/test/cli/version.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ function tmpfile(): string {
}

beforeEach(() => {
jest.spyOn(npm, 'getLatestVersionFromNpm').mockRejectedValue(new Error('expected version cache to be used, but call to npm was attempted'));
process.chdir(os.tmpdir()); // Need a chdir because in the workspace 'npm view' will take a long time
});

Expand Down Expand Up @@ -53,6 +54,7 @@ test('Skip version check if cache has not expired', async () => {

test('Return later version when exists & skip recent re-check', async () => {
const cache = new VersionCheckTTL(tmpfile(), 100);
jest.spyOn(npm, 'getLatestVersionFromNpm').mockResolvedValueOnce('1.1.0');
const result = await latestVersionIfHigher('0.0.0', cache);
expect(result).not.toBeNull();
expect((result as string).length).toBeGreaterThan(0);
Expand All @@ -63,6 +65,7 @@ test('Return later version when exists & skip recent re-check', async () => {

test('Return null if version is higher than npm', async () => {
const cache = new VersionCheckTTL(tmpfile(), 100);
jest.spyOn(npm, 'getLatestVersionFromNpm').mockResolvedValueOnce('1.1.0');
const result = await latestVersionIfHigher('100.100.100', cache);
expect(result).toBeNull();
});
Expand Down Expand Up @@ -104,7 +107,7 @@ describe('version message', () => {
test('Prints a message when a new version is available', async () => {
// Given the current version is 1.0.0 and the latest version is 1.1.0
const currentVersion = '1.0.0';
jest.spyOn(npm, 'getLatestVersionFromNpm').mockResolvedValue('1.1.0');
jest.spyOn(npm, 'getLatestVersionFromNpm').mockResolvedValueOnce('1.1.0');
const printSpy = jest.spyOn(logging, 'info');

// When displayVersionMessage is called
Expand All @@ -117,7 +120,7 @@ describe('version message', () => {
test('Includes major upgrade documentation when available', async() => {
// Given the current version is 1.0.0 and the latest version is 2.0.0
const currentVersion = '1.0.0';
jest.spyOn(npm, 'getLatestVersionFromNpm').mockResolvedValue('2.0.0');
jest.spyOn(npm, 'getLatestVersionFromNpm').mockResolvedValueOnce('2.0.0');
const printSpy = jest.spyOn(logging, 'info');

// When displayVersionMessage is called
Expand All @@ -130,7 +133,7 @@ describe('version message', () => {
test('Does not include major upgrade documentation when unavailable', async() => {
// Given current version is 99.0.0 and the latest version is 100.0.0
const currentVersion = '99.0.0';
jest.spyOn(npm, 'getLatestVersionFromNpm').mockResolvedValue('100.0.0');
jest.spyOn(npm, 'getLatestVersionFromNpm').mockResolvedValueOnce('100.0.0');
const printSpy = jest.spyOn(logging, 'info');

// When displayVersionMessage is called
Expand Down
Loading