-
Notifications
You must be signed in to change notification settings - Fork 69
feat(integ-runner): add --strict flag to throw error on missing tests #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #929 +/- ##
==========================================
- Coverage 83.45% 83.02% -0.44%
==========================================
Files 71 71
Lines 10401 10401
Branches 1317 1303 -14
==========================================
- Hits 8680 8635 -45
- Misses 1680 1727 +47
+ Partials 41 39 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the change
This PR adds a new flag
--strictto integ-runner. When enabled, this flag enforces that all specified tests are found and can be run.With
strict=true, integ-runner will throw an error when any specified tests are not found.Reason for this change
For the Integration Test Workflow, we want to throw an error if some specified tests are not found. This ensures that all tests that have been changed in a PR are actually run in the workflow.
Currently, integ-runner does not throw an error when tests are not found. We can use the
--strictflag in the workflow for our use case.Test
Added unit tests to verify the functionality of the new flag.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.