Skip to content

Conversation

@abidhasan-aws
Copy link
Contributor

@abidhasan-aws abidhasan-aws commented Nov 5, 2025

Description of the change

This PR adds a new flag --strict to integ-runner. When enabled, this flag enforces that all specified tests are found and can be run.

With strict = true, integ-runner will throw an error when any specified tests are not found.

Reason for this change

For the Integration Test Workflow, we want to throw an error if some specified tests are not found. This ensures that all tests that have been changed in a PR are actually run in the workflow.

Currently, integ-runner does not throw an error when tests are not found. We can use the --strict flag in the workflow for our use case.

Test

Added unit tests to verify the functionality of the new flag.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@aws-cdk-automation aws-cdk-automation requested a review from a team November 5, 2025 18:15
@github-actions github-actions bot added the p2 label Nov 5, 2025
@abidhasan-aws abidhasan-aws marked this pull request as ready for review November 5, 2025 18:18
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.02%. Comparing base (d1b4113) to head (a1b2938).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #929      +/-   ##
==========================================
- Coverage   83.45%   83.02%   -0.44%     
==========================================
  Files          71       71              
  Lines       10401    10401              
  Branches     1317     1303      -14     
==========================================
- Hits         8680     8635      -45     
- Misses       1680     1727      +47     
+ Partials       41       39       -2     
Flag Coverage Δ
suite.unit 83.02% <ø> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrgrain mrgrain added this pull request to the merge queue Nov 6, 2025
Merged via the queue into main with commit c0d5863 Nov 6, 2025
43 of 44 checks passed
@mrgrain mrgrain deleted the abidhasan/add-strict-flag-to-integ-runner branch November 6, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants