chore: add ADC publishing workflow #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration lives in the 'releasing' environment, and the bucket names are masked away from the logs.
rix0rrr
had a problem deploying
to
integ-approval
GitHub Actions
Failure
projenrc/publish-to-adc.task.ts
Outdated
|
|
||
| const root = 'dist/standalone'; | ||
|
|
||
| const standaloneFiles = await glob('**/*', { cwd: root }); |
Contributor
There was a problem hiding this comment.
There is a risk here of accidentally publishing something we don't intend to. Normally this wouldn't be an issue, but ADC regions have such stringent policies and processes, that I can see someone paging us over this. Should we have an allowlist?
mrgrain
reviewed
Feb 21, 2025
.github/workflows/release.yml
Outdated
| permissions: | ||
| contents: write | ||
| environment: releasing | ||
| if: ${{ needs.release.outputs.latest_commit == github.sha && needs.release.outputs.publish-aws-cdk-cloud-assembly-schema == 'true' }} |
mrgrain
reviewed
Feb 21, 2025
projenrc/adc-publishing.ts
Outdated
| permissions: { | ||
| contents: JobPermission.WRITE, | ||
| }, | ||
| if: `\${{ needs.release.outputs.latest_commit == github.sha && needs.release.outputs.publish-aws-cdk-cloud-assembly-schema == 'true' }}`, |
Contributor
There was a problem hiding this comment.
why check publish-aws-cdk-cloud-assembly-schema?
Contributor
Author
There was a problem hiding this comment.
Ah, copy/paste-o. Thanks.
rix0rrr
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
otaviomacedo
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration lives in the 'releasing' environment, and the bucket names are masked away from the logs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license