-
Notifications
You must be signed in to change notification settings - Fork 69
fix(aws-cdk): init templates use outdate node types #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #941 +/- ##
==========================================
+ Coverage 83.83% 84.05% +0.22%
==========================================
Files 71 71
Lines 10437 10437
Branches 1335 1334 -1
==========================================
+ Hits 8750 8773 +23
+ Misses 1648 1626 -22
+ Partials 39 38 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
packages/aws-cdk/lib/init-templates/lib/typescript/package.json
Outdated
Show resolved
Hide resolved
packages/aws-cdk/lib/init-templates/sample-app/typescript/package.json
Outdated
Show resolved
Hide resolved
packages/aws-cdk/lib/init-templates/app/typescript/package.json
Outdated
Show resolved
Hide resolved
mrgrain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! See comments.
Head branch was pushed to by a user without write access
Co-authored-by: Momo Kornher <[email protected]>
Fixes #935
The app needs to be on node@24, as we would like customers to run their applications on latest LTS of Node.js.
The lib needs to be node@20, as we would like customers to support minimum number of supported Node.js version.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license