Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Nov 14, 2025

Fixes #935

The app needs to be on node@24, as we would like customers to run their applications on latest LTS of Node.js.
The lib needs to be node@20, as we would like customers to support minimum number of supported Node.js version.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.05%. Comparing base (30ee4c9) to head (274d6bf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #941      +/-   ##
==========================================
+ Coverage   83.83%   84.05%   +0.22%     
==========================================
  Files          71       71              
  Lines       10437    10437              
  Branches     1335     1334       -1     
==========================================
+ Hits         8750     8773      +23     
+ Misses       1648     1626      -22     
+ Partials       39       38       -1     
Flag Coverage Δ
suite.unit 84.05% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See comments.

@mrgrain mrgrain changed the title chore(aws-cdk): use node 24 in app and node 20 in lib fix(aws-cdk): init templates use outdate node types Nov 14, 2025
auto-merge was automatically disabled November 14, 2025 17:28

Head branch was pushed to by a user without write access

@mrgrain mrgrain added this pull request to the merge queue Nov 18, 2025
Merged via the queue into aws:main with commit 1847bfe Nov 18, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws-cdk): use Node.js 24 LTS when initializing a CDK project

3 participants