feat(cli): stabilize --telemetry-file option
#988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
kaizencc
changed the title
--telemetry-file option--telemetry-file option
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #988 +/- ##
==========================================
+ Coverage 87.39% 87.43% +0.04%
==========================================
Files 72 72
Lines 10027 10023 -4
Branches 1314 1314
==========================================
+ Hits 8763 8764 +1
+ Misses 1240 1235 -5
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iliapolo
reviewed
Dec 12, 2025
| caBundlePath: configuration.settings.get(['caBundlePath']), | ||
| }); | ||
|
|
||
| if (argv['telemetry-file'] && !configuration.settings.get(['unstable']).includes('telemetry')) { |
Contributor
There was a problem hiding this comment.
Will running with --unstable=telemetry-file still work?
Contributor
Author
There was a problem hiding this comment.
yes, we're only deleting a check. but also i tested it
iliapolo
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--telemetry-fileoption no longer needs to be included with--unstable=telemetry.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license