fix(cli): drop invalid commands from telemetry#997
Merged
Conversation
iliapolo
had a problem deploying
to
integ-approval
GitHub Actions
Failure
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aws-cdk-automation
had a problem deploying
to
integ-approval
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
==========================================
+ Coverage 87.58% 87.60% +0.01%
==========================================
Files 72 72
Lines 10023 10034 +11
Branches 1316 1321 +5
==========================================
+ Hits 8779 8790 +11
Misses 1220 1220
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iliapolo
changed the title
iliapolo
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
iliapolo
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
iliapolo
commented
Dec 17, 2025
| logLevel: 'trace', | ||
| }, true); | ||
| await telemetryIoHost.startTelemetry({ '_': 'init', 'telemetry-file': telemetryFilePath }, new Context()); | ||
| await telemetryIoHost.startTelemetry({ '_': ['init'], 'telemetry-file': telemetryFilePath }, new Context()); |
Contributor
Author
There was a problem hiding this comment.
This was wrong before - just didn't impact test assertion
rix0rrr
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should only capture CLI sessions that were invoked with a valid subcommand.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license