-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: make L2 interfaces extend I[ResourceName]Ref
#35151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make L2 interfaces extend I[ResourceName]Ref
#35151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
…ef-interface-L2s-extension
…ef-interface-L2s-extension # Conflicts: # packages/aws-cdk-lib/aws-ecs/lib/base/base-service.ts # tools/@aws-cdk/spec2cdk/lib/cdk/resource-class.ts
…ef-interface-L2s-extension
…ef-interface-L2s-extension
ICfn[ResourceName]
I[ResourceName]Ref
Comments on closed issues and PRs are hard for our team to see. |
First batch of L2 interfaces that extend the new
I[ResourceName]Ref
interfaces. Example:The goal is to allow classes that now only consume L2 resources, to consume both L1 or L2 via this new interface. Continuing with the example, this is what
ApiMappingProps
looks like:At the moment,
ApiMappingProps.domainName
can only be an L2. This change will allow us to makeApiMappingProps
more generic:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license