feat(ecr): make enableAutoDeleteImages method public
#36246
Draft
+71
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
requested changes
Nov 30, 2025
Collaborator
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
This was referenced Nov 30, 2025
c19yamamoto
changed the title
enableAutoDeleteImages method publicenableAutoDeleteImages method public
Contributor
|
||||||||||||||
Contributor
|
||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
none
Reason for this change
The functionality that enables the deletion of all images within an ECR Repository when the CDK stack is destroyed (configured via the
emptyOnDelete,autoDeleteImagesproperty) is currently only settable through theRepositoryPropsconstructor. This requires users to decide on the image cleanup behavior at the time of resource creation.The use case for this change is to enable users to activate this capability after the repository has been created (e.g., inside an aspect, a custom method, or dynamically based on conditions), by exposing the internal logic through a public method.
Description of changes
The private method
enableAutoDeleteImages()was changed to publicDescribe any new or updated permissions being added
none
Description of how you validated changes
Add unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license