feat(ec2): support Firehose IDeliveryStreamRef as flow log destination
#36278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Re-drive of #33883 and #34596.
Related to #33757.
Reason for this change
FlowLogDestination.toKinesisDataFirehoseDestination()includes the former service name Kinesis and receives the string ARN.Also, cross-account log delivery needs an IAM role. https://docs.aws.amazon.com/vpc/latest/userguide/firehose-cross-account-delivery.html
Description of changes
FlowLogDestination.toFirehose()with an optional IAM role.toKinesisDataFirehoseDestination()Note: CDK cannot create the IAM role for cross-account delivery because the VPC ARN is needed but FlowLog construct doesn't know it.
Changes from previous PRs
This PR refers the new reference interface
IDeliveryStreamRef(defined ininterfacessubmodule) to avoid cyclic dependency.BEFORE
AFTER
Describe any new or updated permissions being added
N/A - Users must specify IAM roles for cross account delivery.
Description of how you validated changes
Unit tests and integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license