Skip to content

fix(ecs): enableDeploymentAlarms should mutate the alarmNames property #36309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vito-laurenza-zocdoc wants to merge 6 commits into
base: main
Choose a base branch
from
+177 −125
Open

fix(ecs): enableDeploymentAlarms should mutate the alarmNames property #36309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be1f5ee
chore(ecs): add test showing bug in enableDeploymentAlarms
vito-laurenza-zocdoc Dec 5, 2025
49ef68e
fix(ecs): enableDeploymentAlarms should mutate the alarmNames property
vito-laurenza-zocdoc Dec 5, 2025
015f942
chore(ecs): add integration test coverage
vito-laurenza-zocdoc Dec 8, 2025
62166e0
chore: slight test case improvement
vito-laurenza-zocdoc Dec 9, 2025
24d4211
Merge branch 'main' into fix-enableDeploymentAlarms
vito-laurenza-zocdoc Dec 9, 2025
b1cc31e
Merge branch 'main' into fix-enableDeploymentAlarms
vito-laurenza-zocdoc Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...nteg.blue-green-deployment-strategy.js.snapshot/aws-ecs-blue-green-deployment.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions ...eg.blue-green-deployment-strategy.js.snapshot/aws-ecs-blue-green-deployment.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/base/integ.blue-green-deployment-strategy.js.snapshot/aws-ecs-blue-green-deployment.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results

ec2-no-open-security-groups.guard 

EC2_NO_OPEN_SECURITY_GROUPS for Type: Static
Raw output 
Check was not compliant as property value [Path=/Resources/LBSecurityGroup4464B654/Properties/SecurityGroupIngress/0/CidrIp[L:470,C:16] Value="0.0.0.0/0"] equal to value [Path=[L:0,C:0] Value="0.0.0.0/0"].
Check was not compliant as property [SecurityGroupIngress[*]] is missing. Value traversed to [Path=/Resources/ECSSecurityGroupA14DBE7D/Properties[L:484,C:17] Value={"GroupDescription":"aws-ecs-blue-green-deployment/ECSSecurityGroup","SecurityGroupEgress":[{"CidrIp":"0.0.0.0/0","Description":"Allow all outbound traffic by default","IpProtocol":"-1"}],"VpcId":{"Ref":"Vpc8378EB38"}}]

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/base/integ.blue-green-deployment-strategy.js.snapshot/aws-ecs-blue-green-deployment.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results

iam-no-wildcard-actions-inline.guard 

IAM_NO_WILDCARD_ACTIONS_INLINE for Type: Static
Raw output 
Check was not compliant as property [Policies[*].PolicyDocument.Statement[*]] is missing. Value traversed to [Path=/Resources/LambdaHookServiceRole9AAAD33B/Properties[L:618,C:17] Value={"AssumeRolePolicyDocument":{"Statement":[{"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"Service":"lambda.amazonaws.com"}}],"Version":"2012-10-17"},"ManagedPolicyArns":[{"Fn::Join":["",["arn:",{"Ref":"AWS::Partition"},":iam::aws:policy/service-role/AWSLambdaBasicExecutionRole"]]}]}]
Check was not compliant as property [Policies[*].PolicyDocument.Statement[*]] is missing. Value traversed to [Path=/Resources/TaskDefTaskRole1EDB4A67/Properties[L:687,C:17] Value={"AssumeRolePolicyDocument":{"Statement":[{"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"Service":"ecs-tasks.amazonaws.com"}}],"Version":"2012-10-17"}}]
Check was not compliant as property [Policies[*].PolicyDocument.Statement[*]] is missing. Value traversed to [Path=/Resources/ServiceLBAlternateOptionsRole06C91D94/Properties[L:835,C:17] Value={"AssumeRolePolicyDocument":{"Statement":[{"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"Service":"ecs.amazonaws.com"}}],"Version":"2012-10-17"},"ManagedPolicyArns":[{"Fn::Join":["",["arn:",{"Ref":"AWS::Partition"},":iam::aws:policy/AmazonECSInfrastructureRolePolicyForLoadBalancers"]]}]}]
Check was not compliant as property [Policies[*].PolicyDocument.Statement[*]] is missing. Value traversed to [Path=/Resources/ServicePreScaleUpRoleD002A553/Properties[L:869,C:17] Value={"AssumeRolePolicyDocument":{"Statement":[{"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"Service":"ecs.amazonaws.com"}}],"Version":"2012-10-17"}}]

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/base/integ.blue-green-deployment-strategy.js.snapshot/aws-ecs-blue-green-deployment.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results with resolved templates

ec2-no-open-security-groups.guard 

EC2_NO_OPEN_SECURITY_GROUPS for Type: Resolved
Raw output 
Check was not compliant as property value [Path=/Resources/LBSecurityGroup4464B654/Properties/SecurityGroupIngress/0/CidrIp[L:365,C:22] Value="0.0.0.0/0"] equal to value [Path=[L:0,C:0] Value="0.0.0.0/0"].
Check was not compliant as property [SecurityGroupIngress[*]] is missing. Value traversed to [Path=/Resources/ECSSecurityGroupA14DBE7D/Properties[L:377,C:20] Value={"GroupDescription":"aws-ecs-blue-green-deployment/ECSSecurityGroup","SecurityGroupEgress":[{"CidrIp":"0.0.0.0/0","Description":"Allow all outbound traffic by default","IpProtocol":"-1"}],"VpcId":"Vpc8378EB38"}]

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/base/integ.blue-green-deployment-strategy.js.snapshot/aws-ecs-blue-green-deployment.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results with resolved templates

iam-no-wildcard-actions-inline.guard 

IAM_NO_WILDCARD_ACTIONS_INLINE for Type: Resolved
Raw output 
Check was not compliant as property [Policies[*].PolicyDocument.Statement[*]] is missing. Value traversed to [Path=/Resources/LambdaHookServiceRole9AAAD33B/Properties[L:482,C:20] Value={"AssumeRolePolicyDocument":{"Version":"2012-10-17","Statement":[{"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"Service":"lambda.amazonaws.com"}}]},"ManagedPolicyArns":["arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole"]}]
Check was not compliant as property [Policies[*].PolicyDocument.Statement[*]] is missing. Value traversed to [Path=/Resources/TaskDefTaskRole1EDB4A67/Properties[L:525,C:20] Value={"AssumeRolePolicyDocument":{"Version":"2012-10-17","Statement":[{"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"Service":"ecs-tasks.amazonaws.com"}}]}}]
Check was not compliant as property [Policies[*].PolicyDocument.Statement[*]] is missing. Value traversed to [Path=/Resources/ServiceLBAlternateOptionsRole06C91D94/Properties[L:630,C:20] Value={"AssumeRolePolicyDocument":{"Version":"2012-10-17","Statement":[{"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"Service":"ecs.amazonaws.com"}}]},"ManagedPolicyArns":["arn:aws:iam::aws:policy/AmazonECSInfrastructureRolePolicyForLoadBalancers"]}]
Check was not compliant as property [Policies[*].PolicyDocument.Statement[*]] is missing. Value traversed to [Path=/Resources/ServicePreScaleUpRoleD002A553/Properties[L:653,C:20] Value={"AssumeRolePolicyDocument":{"Version":"2012-10-17","Statement":[{"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"Service":"ecs.amazonaws.com"}}]}}]
"Resources": {
"Vpc8378EB38": {
"Type": "AWS::EC2::VPC",
Expand Down Expand Up @@ -740,6 +740,18 @@
"Ref": "FargateCluster7CCD5F93"
},
"DeploymentConfiguration": {
"Alarms": {
"AlarmNames": [
{
"Ref": "MyCustomAlarmBBB0BEE1"
},
{
"Ref": "AnotherCustomAlarm221DEB18"
}
],
"Enable": true,
"Rollback": true
},
"LifecycleHooks": [
{
"HookTargetArn": {
Expand Down Expand Up @@ -911,6 +923,30 @@
}
]
}
},
"MyCustomAlarmBBB0BEE1": {
"Type": "AWS::CloudWatch::Alarm",
"Properties": {
"ComparisonOperator": "GreaterThanOrEqualToThreshold",
"EvaluationPeriods": 2,
"MetricName": "MyCustomMetric",
"Namespace": "Custom",
"Period": 300,
"Statistic": "Average",
"Threshold": 80
}
},
"AnotherCustomAlarm221DEB18": {
"Type": "AWS::CloudWatch::Alarm",
"Properties": {
"ComparisonOperator": "GreaterThanOrEqualToThreshold",
"EvaluationPeriods": 2,
"MetricName": "AnotherCustomMetric",
"Namespace": "Custom",
"Period": 300,
"Statistic": "Average",
"Threshold": 80
}
}
},
"Parameters": {
Expand Down
2 changes: 1 addition & 1 deletion ...-integ/test/aws-ecs/test/base/integ.blue-green-deployment-strategy.js.snapshot/integ.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

187 changes: 70 additions & 117 deletions ...teg/test/aws-ecs/test/base/integ.blue-green-deployment-strategy.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...k-integ/test/aws-ecs/test/base/integ.blue-green-deployment-strategy.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading