Skip to content

Conversation

@tnb-git
Copy link
Contributor

@tnb-git tnb-git commented Dec 6, 2025

Issue

Closes #35720 .

Reason for this change

This change fixes an issue in the RDS OptionGroup L2 construct where some parameter settings were not correctly reflected in CloudFormation.

Description of changes

  • Added support for additional parameters in the OptionGroup L2 construct.
  • Updated the integration test (integ.option-group.ts)
  • No impact on existing default settings.

Describe any new or updated permissions being added

No extra permissions needed

Description of how you validated changes

Added a unit test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 6, 2025 04:57
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Dec 6, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

TestsPassed ✅SkippedFailed
Security Guardian Results52 ran52 passed0 skipped0 failed
TestResult
No test annotations available

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

TestsPassed ✅SkippedFailed
Security Guardian Results with resolved templates52 ran52 passed0 skipped0 failed
TestResult
No test annotations available

@aws-cdk-automation aws-cdk-automation dismissed their stale review December 6, 2025 06:08

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-rds: Add option group name parameter

2 participants