Skip to content

Conversation

AndrewAsseily
Copy link
Contributor

@AndrewAsseily AndrewAsseily commented Jul 28, 2025

Issue #, if available: CLI-4867

Description of changes:
This enhancement addresses the issue reported in #7758, where users were encountering unclear error messages when attempting to import CSV credentials.
This change improves the documentation and error messaging for the aws configure import --csv
command when the file:// prefix is missing from file paths.

Testing:

  1. Ran Unit tests
  2. Built and reviewed documentation changes
  3. Manually tested scenarios:
    1. Missing file:// prefix:

      ./bin/aws configure import --csv test-creds.csv
      

      Result: Shows error message

      You may be passing a file to import without the 'file://' prefix. To import a CSV file, use --csv file://path/to/file.csv

    2. Correct file path format:

      ./bin/aws configure import --csv file://test-creds.csv
      

      Result: Shows success message

      Successfully imported 1 profile(s)

    3. Inline CSV data:

      ./bin/aws configure import --csv "User Name,Access Key ID,Secret Access Key
      my-user,*************,inlinekeyvalue"
      

      Result: Shows success message

      Successfully imported 1 profile(s)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute
this contribution, under the terms of your choice.

Copy link
Member

@kdaily kdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! One note on the error that we can raise.

@AndrewAsseily AndrewAsseily requested a review from kdaily July 29, 2025 13:47
Copy link
Member

@kdaily kdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of minor changes, but this change should improve customer experience in adding creds from CSV files!

@AndrewAsseily AndrewAsseily requested a review from kdaily August 14, 2025 15:39
@AndrewAsseily AndrewAsseily merged commit 31156eb into aws:v2 Aug 14, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants