kn: address misc issues #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
changed the title
This comment has been minimized.
This comment has been minimized.
lauzadis
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
ianbotsf
approved these changes
Aug 13, 2025
Comment on lines
228
to
236
| val kShouldSignHeaderFn = userData.asStableRef<ShouldSignHeaderFunction>().get() | ||
| val kShouldSignHeaderStableRef = userData.asStableRef<ShouldSignHeaderFunction>() | ||
| val kShouldSignHeaderFn = kShouldSignHeaderStableRef.get() | ||
| val kHeaderName = headerName.pointed.toKString() | ||
| return kShouldSignHeaderFn(kHeaderName) | ||
| return kShouldSignHeaderFn(kHeaderName).also { | ||
| kShouldSignHeaderStableRef.dispose() | ||
| } |
Contributor
There was a problem hiding this comment.
Question: Is it important to dispose stable refs even when an exception occurs? If so, I think your use method may be appropriate here:
userData.asStableRef<ShouldSignHeaderFunction>().use { kShouldSignHeaderStableRef ->
val kShouldSignHeaderFn = kShouldSignHeaderStableRef.get()
val kHeaderName = headerName.pointed.toKString()
return kShouldSignHeaderFn(kHeaderName)
}
Member
Author
There was a problem hiding this comment.
Yes it is, we should be disposing every StableRef created. I updated to use the use method
Comment on lines
109
to
111
| } finally { | ||
| ctxStableRef.dispose() | ||
| } |
Contributor
There was a problem hiding this comment.
Question: Would it be better to use your use method here?
Comment on lines
94
to
98
| pointer.pointed.buffer = if (dest.isNotEmpty()) { | ||
| pinned.addressOf(0).reinterpret() | ||
| } else { | ||
| null | ||
| } |
Contributor
There was a problem hiding this comment.
Style:
takeIf or takeUnless can clean this up a bit:
pointer.pointed.buffer = pinned.takeUnless { dest.isEmpty() }?.addressOf(0)?.reinterpret()
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
Affected ArtifactsChanged in size
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Address various issues raised during code review
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.