kn: release setup #174
Merged
kn: release setup #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… intended as a public API.`
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lauzadis
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ianbotsf
reviewed
Aug 11, 2025
Comment on lines
71
to
-72
| ### Windows | ||
| Not supported yet. |
Contributor
There was a problem hiding this comment.
Question: Can we add build instructions? I should've done that in my K/N Windows PRs but I didn't realize/remember this was here.
Member
Author
There was a problem hiding this comment.
I have not built on Windows using our containers, is there anything we need to do besides running the script and ensuring Docker is installed?
Comment on lines
14
to
15
|
|
||
| fun KotlinNativeTarget.namedSuffix(prefix: String, capitalized: Boolean = false): String = | ||
| prefix + if (capitalized) name.capitalized() else name | ||
| prefix + if (capitalized) name.uppercase() else name |
Contributor
There was a problem hiding this comment.
Nit: If we're uppercasing then the parameter name capitalized is no longer accurate.
This comment has been minimized.
This comment has been minimized.
|
Affected ArtifactsChanged in size
|
ianbotsf
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Get aws-crt-kotlin ready to build and release K/N artifacts
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.