chore: fix some broken K/N tests by upgrading CRT submodules and adding WithCrt to some native resources #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng WithCrt to some native resources
ianbotsf
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
Affected ArtifactsChanged in size
|
lauzadis
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
(none)
Description of changes:
This change bumps the CRT submodules to their latest HEAD commits and adds
WithCrt()as a base class for the nativeMain implementations ofClientBootstrapandEventLoopGroup. These changes will allow removing the remaining@IgnoreNativeannotations on some tests in smithy-kotlin,By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.