fix: GHA typo

.github/workflows/README.md

@@ -0,0 +1,22 @@
+[//]: # "Copyright Amazon.com Inc. or its affiliates. All Rights Reserved."
+[//]: # "SPDX-License-Identifier: CC-BY-SA-4.0"
+
+# GitHub Actions
+
+The MPL uses GitHub Actions to trigger our testing.
+If a GitHub Action job/workflow is going to be added, and that job should always run, it should be added to `ci.yml`.
+
+This stops us from having multiple copies of the same event.
+
+Instead, we build a hierarchy of testing:
+
+- `routine_ci` determines regular testing events, such as daily, PR, or push to main
+- `ci.yml` is triggered by `routine_ci` or other events, and runs all the per runtime testing
+- `library_<runtime>_tests` are responsible for a runtimes particular testing suite.
+
+# `library_<runtime>_tests`
+
+In general, these should have at least two inputs:
+
+- The Dafny Verision
+- Weather Smithy-Dafny should be re-run

.github/workflows/check_dafny_runtime_versions.yml

@@ -5,10 +5,8 @@
 name: Check DafnyRuntimePython Version Consistency
 
 on:
-  pull_request:
-  push:
-    branches:
-      - main
+  workflow_call:
+  workflow_dispatch:
 
 jobs:
   check-version-consistency:

.github/workflows/check-files.yml → .github/workflows/check_files.yml

@@ -3,7 +3,8 @@
 name: Check Release Files
 
 on:
-  pull_request:
+  workflow_call:
+  workflow_dispatch:
 
 jobs:
   require-approvals:
@@ -14,7 +15,7 @@ jobs:
     env:
       # unfortunately we can't check if the approver is part of the CODEOWNERS. This is a subset of aws/aws-crypto-tools-team
       # to add more allowlisted approvers just modify this env variable
-      maintainers: seebees, texastony, ShubhamChaturvedi7, lucasmcdonald3, josecorella, imabhichow, rishav-karanjit, antonf-amzn, kessplas, RitvikKapila, ajewellamz
+      maintainers: seebees, texastony, ShubhamChaturvedi7, lucasmcdonald3, josecorella, imabhichow, rishav-karanjit, antonf-amzn, kessplas, ajewellamz
     steps:
       - uses: actions/checkout@v3
         with:

.github/workflows/check_only_keyword.yml

@@ -4,7 +4,8 @@
 name: Check {:only} decorator presence
 
 on:
-  pull_request:
+  workflow_call:
+  workflow_dispatch:
 
 jobs:
   grep-only-verification-keyword:

.github/workflows/ci.yml

@@ -0,0 +1,119 @@
+# These are all the tests needed in general
+name: Continious Integration Tests
+
+on:
+  # This workflow is invoked by other workflows with the requested Dafny build.
+  # It represents all the required testing for the MPL.
+  workflow_dispatch:
+    inputs:
+      dafnyTranspilerVersion:
+        description: "The Dafny Transpiler and Runtime to use for all but Rust"
+        required: true
+        type: string
+      dafnyVerifyVersion:
+        description: "The Dafny Verifier Version to use"
+        required: true
+        type: string
+      dafnyRustVersion:
+        description: "The Dafny Transpiler and Runtime to use for Rust"
+        required: true
+        type: string
+      regenerate-code:
+        description: "Regenerate code using smithy-dafny"
+        required: false
+        default: false
+        type: boolean
+  workflow_call:
+    inputs:
+      dafnyTranspilerVersion:
+        description: "The Dafny Transpiler and Runtime to use for all but Rust"
+        required: true
+        type: string
+      dafnyVerifyVersion:
+        description: "The Dafny Verifier Version to use"
+        required: true
+        type: string
+      dafnyRustVersion:
+        description: "The Dafny Transpiler and Runtime to use for Rust"
+        required: true
+        type: string
+      regenerate-code:
+        description: "Regenerate code using smithy-dafny"
+        required: false
+        default: false
+        type: boolean
+
+jobs:
+  sem-ver:
+    uses: ./.github/workflows/sem_ver.yml
+  check-files:
+    uses: ./.github/workflows/check_files.yml
+  check-only:
+    uses: ./.github/workflows/check_only_keyword.yml
+  ci-not-grep:
+    uses: ./.github/workflows/ci_static_analysis.yml
+  ci-format:
+    uses: ./.github/workflows/library_format.yml
+    with:
+      dafny: ${{ inputs.dafnyVerifyVersion }}
+      regenerate-code: ${{ inputs.regenerate-code }}
+  ci-codegen:
+    uses: ./.github/workflows/library_codegen.yml
+    with:
+      dafny: ${{ inputs.dafnyVerifyVersion }}
+  ci-verification:
+    uses: ./.github/workflows/library_dafny_verification.yml
+    with:
+      dafny: ${{ inputs.dafnyVerifyVersion }}
+      regenerate-code: ${{ inputs.regenerate-code }}
+  ci-java:
+    uses: ./.github/workflows/library_java_tests.yml
+    with:
+      dafny: ${{ inputs.dafnyVerifyVersion }}
+      regenerate-code: ${{ inputs.regenerate-code }}
+  ci-net:
+    uses: ./.github/workflows/library_net_tests.yml
+    with:
+      dafny: ${{ inputs.dafnyVerifyVersion }}
+      regenerate-code: ${{ inputs.regenerate-code }}
+  ci-rust:
+    uses: ./.github/workflows/library_rust_tests.yml
+    with:
+      dafny: ${{ inputs.dafnyRustVersion }}
+      # Rust always regenerates code
+  ci-python-check-version-consistency:
+    uses: ./.github/workflows/check_dafny_runtime_versions.yml
+  ci-python:
+    uses: ./.github/workflows/library_python_tests.yml
+    with:
+      dafny: ${{ inputs.dafnyVerifyVersion }}
+      regenerate-code: ${{ inputs.regenerate-code }}
+  ci-go:
+    uses: ./.github/workflows/library_go_tests.yml
+    with:
+      dafny: ${{ inputs.dafnyVerifyVersion }}
+      regenerate-code: ${{ inputs.regenerate-code }}
+  interop-test:
+    uses: ./.github/workflows/library_interop_tests.yml
+    with:
+      dafny: ${{ inputs.dafnyVerifyVersion }}
+      regenerate-code: ${{ inputs.regenerate-code }}
+    secrets: inherit
+  all-required:
+    if: always()
+    needs:
+      - ci-format
+      - ci-codegen
+      - ci-verification
+      - ci-java
+      - ci-net
+      - ci-python
+      - ci-go
+      - ci-rust
+      - interop-test
+    runs-on: ubuntu-22.04
+    steps:
+      - name: Verify all required jobs passed
+        uses: re-actors/alls-green@release/v1
+        with:
+          jobs: ${{ toJSON(needs) }}

.github/workflows/ci_static-analysis.yaml → .github/workflows/ci_static_analysis.yml

@@ -2,10 +2,8 @@
 name: static analysis
 
 on:
-  pull_request:
-  push:
-    branches:
-      - main
+  workflow_call:
+  workflow_dispatch:
 
 jobs:
   not-grep:

.github/workflows/library_codegen.yml

@@ -78,6 +78,6 @@ jobs:
 
       - uses: ./.github/actions/polymorph_codegen
         with:
-          dafny: ${{ env.DAFNY_VERSION }}
+          dafny: ${{ inputs.dafny }}
           library: ${{ matrix.library }}
           diff-generated-code: true

.github/workflows/library_dafny_verification.yml

@@ -59,7 +59,7 @@ jobs:
         if: ${{ inputs.regenerate-code }}
         uses: ./.github/actions/polymorph_codegen
         with:
-          dafny: ${{ env.DAFNY_VERSION }}
+          dafny: ${{ inputs.dafny }}
           library: ${{ matrix.library }}
           diff-generated-code: false
 

.github/workflows/library_format.yml

@@ -16,8 +16,6 @@ on:
 
 jobs:
   format_projects:
-    # Don't run the nightly build on forks
-    if: github.event_name != 'schedule' || github.repository_owner == 'aws'
     strategy:
       matrix:
         library:
@@ -81,11 +79,9 @@ jobs:
           # This works because `node` is installed by default on GHA runners
           CORES=$(node -e 'console.log(os.cpus().length)')
           make format_net-check
+
   format_java_misc:
-    # Don't run the nightly build on forks
-    if: github.event_name != 'schedule' || github.repository_owner == 'aws'
     runs-on: ubuntu-22.04
-
     steps:
       - name: Support longpaths
         run: |

.github/workflows/library_go_tests.yml

@@ -80,6 +80,14 @@ jobs:
       - name: Install Smithy-Dafny codegen dependencies
         uses: ./.github/actions/install_smithy_dafny_codegen_dependencies
 
+      - name: Regenerate code using smithy-dafny if necessary
+        if: ${{ inputs.regenerate-code }}
+        uses: ./.github/actions/polymorph_codegen
+        with:
+          dafny: ${{ inputs.dafny }}
+          library: ${{ matrix.library }}
+          diff-generated-code: false
+
       - name: Build ${{ matrix.library }} implementation
         working-directory: ./${{ matrix.library }}
         run: |

.github/workflows/library_java_tests.yml

@@ -72,7 +72,7 @@ jobs:
         if: ${{ inputs.regenerate-code }}
         uses: ./.github/actions/polymorph_codegen
         with:
-          dafny: ${{ env.DAFNY_VERSION }}
+          dafny: ${{ inputs.dafny }}
           library: ${{ matrix.library }}
           diff-generated-code: false
 

.github/workflows/library_net_tests.yml

@@ -75,7 +75,7 @@ jobs:
         if: ${{ inputs.regenerate-code }}
         uses: ./.github/actions/polymorph_codegen
         with:
-          dafny: ${{ env.DAFNY_VERSION }}
+          dafny: ${{ inputs.dafny }}
           library: ${{ matrix.library }}
           diff-generated-code: false
 

.github/workflows/library_python_tests.yml

@@ -81,6 +81,14 @@ jobs:
       - name: Install Smithy-Dafny codegen dependencies
         uses: ./.github/actions/install_smithy_dafny_codegen_dependencies
 
+      - name: Regenerate code using smithy-dafny if necessary
+        if: ${{ inputs.regenerate-code }}
+        uses: ./.github/actions/polymorph_codegen
+        with:
+          dafny: ${{ inputs.dafny }}
+          library: ${{ matrix.library }}
+          diff-generated-code: false
+
       - name: Build ${{ matrix.library }} implementation
         working-directory: ./${{ matrix.library }}
         run: |

.github/workflows/library_rust_tests.yml

@@ -8,11 +8,6 @@ on:
         description: "The Dafny version to run"
         required: true
         type: string
-      regenerate-code:
-        description: "Regenerate code using smithy-dafny"
-        required: false
-        default: false
-        type: boolean
 
 jobs:
   testRust: