feat(keystore) Branch Key Store read consistency #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDB offer configurable read consistency, allow for customers to choose eventually consistent reads for optimal cost and performance for their use-case. The Branch Key Store's `GetActiveBranchKey`, `GetBranchKeyVersion`, and `GetBeaconKey` operations utilize AWS DDB `GetItem` calls which now set the `ConsistentRead` flag based on the configuration setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DDB offer configurable read consistency,
allow for customers to choose eventually consistent reads for optimal cost and performance
for their use-case.
The Branch Key Store's
GetActiveBranchKey,GetBranchKeyVersion, andGetBeaconKeyoperations utilize AWS DDBGetItemcalls whichnow set the
ConsistentReadflag based on the configuration setting.See: awslabs/aws-encryption-sdk-specification#302
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.