chore(python): examples for client_supplier#1906
Merged
imabhichow merged 3 commits intopython-reviewedfrom May 30, 2025
Merged
Conversation
Contributor
lucasmcdonald3
left a comment
lucasmcdonald3
left a comment
There was a problem hiding this comment.
Content LGTM -- pending CI being fixed by another PR before approving
...ples/runtimes/python/DynamoDBEncryption/src/client_supplier/regional_role_client_supplier.py
Show resolved
Hide resolved
imabhichow
force-pushed
the
imabhichow/python-examples-clientsupplier
branch
from
8689c5c to
1bdc2e2
Compare
lucasmcdonald3
approved these changes
May 30, 2025
Contributor
lucasmcdonald3
left a comment
lucasmcdonald3
left a comment
There was a problem hiding this comment.
LGTM
Since CI is passing, you should do the following:
- Change base branch to
python-reviewed - Squash and merge. (Ignore failing CI, that's expected)
Examples/runtimes/python/DynamoDBEncryption/src/client_supplier/client_supplier_example.py
Outdated
Show resolved
Hide resolved
…r/client_supplier_example.py Co-authored-by: Lucas McDonald <lucasmcdonald3@gmail.com>
imabhichow
force-pushed
the
imabhichow/python-examples-clientsupplier
branch
from
34fda84 to
b55c13f
Compare
imabhichow
changed the title
lucasmcdonald3
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.