-
Notifications
You must be signed in to change notification settings - Fork 16
chore(go): Add Go release workflow and script #1958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Detected changes to the release files or to the check-files action |
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
Detected changes to the release files or to the check-files action |
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
Detected changes to the release files or to the check-files action |
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
Detected changes to the release files or to the check-files action |
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
Detected changes to the release files or to the check-files action |
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
Detected changes to the release files or to the check-files action |
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
Detected changes to the release files or to the check-files action |
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
Detected changes to the release files or to the check-files action |
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
# ImplementationFromDafny.go: This file is for devlopment. Users is expected use API(s) from `*/api_client.go` | ||
# ImplementationFromDafny-go.dtr: This is the dafny translation record only needed for code generation | ||
# go.sum: This files will be updated by go mod tidy | ||
rsync -av --exclude="ImplementationFromDafny.go" --exclude="ImplementationFromDafny-go.dtr" --exclude="go.sum" ./ "$(git rev-parse --show-toplevel)/releases/go/$RELEASE_DIR_NAME/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: unlike MPL, I am copying go.mod file as well. The reason is because go.mod does not exists (because we have never released DB-ESDK Go). So, all the go related commands (example: goimports, go get, go mod tidy...) won't work. I am also inclining towards making this change in MPL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this, but I trust you
# ImplementationFromDafny.go: This file is for devlopment. Users is expected use API(s) from `*/api_client.go` | ||
# ImplementationFromDafny-go.dtr: This is the dafny translation record only needed for code generation | ||
# go.sum: This files will be updated by go mod tidy | ||
rsync -av --exclude="ImplementationFromDafny.go" --exclude="ImplementationFromDafny-go.dtr" --exclude="go.sum" ./ "$(git rev-parse --show-toplevel)/releases/go/$RELEASE_DIR_NAME/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this, but I trust you
Detected changes to the release files or to the check-files action |
Issue #, if available:
Description of changes:
This workflow and script already exists in MPL.
Triggered workflow: https://github.com/aws/aws-database-encryption-sdk-dynamodb/actions/runs/16228696292/job/45826608148#step:13:12876
Note: This is failing for right reason as we have not released MPL and its supposed to fail because of newly added
memorymath.dfy
in standard library.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.