feat: add min health percent to Fargate recipes #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philasmar
added
the
Release Not Needed
GarrettBeatty
approved these changes
Jun 5, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/net8-upgrade #947 +/- ##
=======================================================
Coverage ? 62.15%
=======================================================
Files ? 294
Lines ? 10784
Branches ? 1612
=======================================================
Hits ? 6703
Misses ? 3485
Partials ? 596 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
philasmar
force-pushed
the
asmarp/add-min-healthy-percent
branch
from
efa23e3 to
c80b4c3
Compare
normj
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add min health percent to Fargate recipes to address the CDK warning:
[Warning at /NET8Web1/Recipe/AppFargateService] minHealthyPercent has not been configured so the default value of 50% is used. The number of running tasks will decrease below the desired count during deployments etc. See aws/aws-cdk#31705 [ack: @aws-cdk/aws-ecs:minHealthyPercent]
CDK defaults this value to 50, though CloudFormation defaults to 100 https://docs.aws.amazon.com/AWSCloudFormation/latest/TemplateReference/aws-properties-ecs-service-deploymentconfiguration.html#cfn-ecs-service-deploymentconfiguration-minimumhealthypercent.
I stuck with 100 as the default to provide users with the behavior they would expect.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.