Skip to content

Conversation

@philasmar
Copy link
Contributor

Issue #, if available:
aws/aws-toolkit-visual-studio#521

Description of changes:
Add the --load flag in docker buildx build because, unlike the standard docker build command, buildx doesn't automatically load the resulting image into the local Docker image store. When using buildx with certain docker drivers (like docker-container), the build process happens in a container, and the resulting image needs to be explicitly loaded into the local image store using --load.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@philasmar philasmar requested review from GarrettBeatty and normj July 15, 2025 14:11
@GarrettBeatty GarrettBeatty requested a review from Copilot July 15, 2025 14:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the --load flag to the docker buildx build command so that built images are automatically loaded into the local Docker image store when using buildx.

  • Update the container build command to include --load for cross-architecture builds
  • Add a changelog entry describing the new flag

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/AWS.Deploy.Orchestration/DeploymentBundleHandler.cs Include --load flag in buildx build command
.autover/changes/aeb80c58-0a88-4bcb-9fc4-c23c4045e6ec.json Add changelog entry for the new --load flag
Comments suppressed due to low confidence (1)

src/AWS.Deploy.Orchestration/DeploymentBundleHandler.cs:69

  • Add a unit test to verify that when building cross-architecture images, the generated buildCommand string includes the --load flag to prevent regressions.
                buildCommand = $"{commandName} buildx build --load --platform {platform} -t {imageTag} -f \"{dockerFile}\"{buildArgs} .";

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.10%. Comparing base (7aa80c4) to head (99f7de5).
Report is 11 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #966      +/-   ##
==========================================
- Coverage   62.14%   62.10%   -0.04%     
==========================================
  Files         294      294              
  Lines       10796    10796              
  Branches     1616     1616              
==========================================
- Hits         6709     6705       -4     
- Misses       3487     3490       +3     
- Partials      600      601       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philasmar philasmar merged commit 54b59a7 into dev Jul 15, 2025
13 of 14 checks passed
@philasmar philasmar deleted the asmarp/add-load-docker-build branch July 15, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants