Update AWS SDK to Preview 11 #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscpinheiro
approved these changes
Mar 27, 2025
muhammad-othman
approved these changes
Mar 27, 2025
philasmar
approved these changes
Mar 28, 2025
philasmar
reviewed
Mar 28, 2025
i dropped it in latest commit |
GarrettBeatty
commented
Mar 31, 2025
| "Projects": [ | ||
| { | ||
| "Name": "Amazon.Extensions.Configuration.SystemsManager", | ||
| "Type": "Patch", |
There was a problem hiding this comment.
need to double check if this should be minor or patch
There was a problem hiding this comment.
Since we are removing targets which is potentially a breaking change we consider that a major change in our HLL.
There was a problem hiding this comment.
updated changelog to be major
normj
requested changes
Mar 31, 2025
| <PropertyGroup> | ||
| <!-- Included netstandard2.0 support for a .NET Framework use-case, see: https://github.com/aws/aws-dotnet-extensions-configuration/pull/150 --> | ||
| <TargetFrameworks>netstandard2.0;netcoreapp3.1;net6.0;net8.0</TargetFrameworks> | ||
| <TargetFrameworks>netstandard2.0;netcoreapp3.1;net8.0</TargetFrameworks> |
There was a problem hiding this comment.
Since we removed .NET 6 we should also remove netcoreapp3.1.
GarrettBeatty
commented
Apr 1, 2025
| { | ||
| if (args.Headers.ContainsKey(UserAgentHeader) && | ||
| #if NETCOREAPP3_1_OR_GREATER | ||
| #if NET8_0_OR_GREATER |
There was a problem hiding this comment.
@normj /@philasmar i believe this is right based on https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/preprocessor-directives#remarks.
normj
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Testing
CI tests pass
Types of changes
Checklist
License