let eb local run generate multi-service docker-compose files#514
Open
dgarbartopti wants to merge 1 commit intoaws:masterfrom
Open
let eb local run generate multi-service docker-compose files#514dgarbartopti wants to merge 1 commit intoaws:masterfrom
eb local run generate multi-service docker-compose files#514dgarbartopti wants to merge 1 commit intoaws:masterfrom
Conversation
partially fixes aws#58, but ideally a full fix would just copy a docker-compose.yml at the root if one existed this just fixes improperly dumping multiple services at the root of the docker-compose and failing validation also it ideally would work with the "ECS" image and not just "Multi-container Docker"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partially fixes #58, but ideally a full fix would just copy a docker-compose.yml at the root if one existed
this just fixes improperly dumping multiple services at the root of the docker-compose and failing validation
also it ideally would work with the "ECS" image and not just "Multi-container Docker"